Loading...
 

History: CSS Selector Questions

Preview of version: 14

This page lists questions about current CSS selectors (just going down the design.css file). Are they still necessary or should they be replaced with Bootstrap selectors?

/* ckeditor body definition */ html[dir=ltr]>body << REMOVED >> #role_main { min-height: 40em; } << REMOVED - Presumably, layout properties like this are covered by Bootstrap. >> /* Some default values for basic CSS menus layout */ .cssmenu_horiz a, .cssmenu_vert a, .cssmenu_horiz ul li a << REMOVED - if needed, it should be in a cssmenu stylesheet section. >> .floatright .floatleft << REMOVED - Should be replaced with equivalent Bootstrap, or removed - check instances in templates. >> .sitetitle, .sitesubtitle { line-height: 1; } << REMOVED >> .iconmenu { display: inline; } label { cursor: pointer; } << Subjective? >> << The .siteloginbar rules were REMOVED as obsolete. >> << The module positioning rules such as for site logo and #sitesearchbar should be replaced by modules with parameters. >> .box-quickadmin << cssmenu styles should be replaced by bootstrap drop-down >> .mod-share-item << Replace by putting in a module? >> .fullscreen .tellafriend, << Replace by putting in a module? >> .fullscreen .share .error.icon { font-weight: bold; color: #090; } << Replace? >> .fullscreenbutton, #fullscreenbutton, << Fullscreen code is currently missing from layout_view.tpl. Should the fullscreen method be re-added, or replaced? >> #tiki-clean << This is for print view, right? Still needed? >> .floatlist << Still needed? >> #attzone, #comzone, #edithelpzone, #rules-copy-panel { display: none; } << Presumably still needed but not sure. >> .clear, #clear { clear: both; } << Are these still needed (we're supporting newer browsers now)? >> .imagerank { margin: 10px 5px; } << Can this (and any similar items) be replaced by a class? >> #tiki-top form.findtable #tiki-top table << REMOVED >> #top_modules .box-quickadmin << Should this be positioned in design.css, or set in admin-modules? The latter, I would think. >> #bottom_modules .box-rsslist br << REMOVED - the br should be removed. >> .mod-share-item .mod-share-item a img .mod-share-item.google-root .fullscreen .tellafriend, .fullscreen .share .share img #rss #power #credits << REMOVED - They should be displayed via modules. >> ul.jumplinks << REMOVED - Probably HTML5 role replaces this, as a visually impaired access method. >> .fullscreenbutton, #fullscreenbutton << What is the best way currently to get the full-screen (For main content) effect? >> #tiki-clean << REMOVED - should be covered by Bootstrap print. >> .floatlist .floatlist li << REMOVED - Though I'm not sure of the purpose. Will check in the templates. >> .mini { width: 100%; text-align: center; margin-left: auto; margin-right: auto; } << Can this be replaced by a Bootstrap class? >> .pagenums input[type="text"] { margin-top: -1px; } a.tikihelp, a.tikihelp:visited { border: 0; vertical-align: text-top; } .iconmenutext { white-space: nowrap; } #rss img, a.icon, img.icon { vertical-align: middle; } << This and the above two are the kinds of rule that really needs to removed, consolidated as a class with other similar cases, or something. >> /** Titles (not boxed) bold lines alone not in summary used by categobjects.tpl + ? **/ .simple_title << There should be a Bootstrap equiv. >> /* New Toolbars */ .textarea-toolbar << ...and related. Are these still needed? >> /* New Help section */ #tikihelp << This is new, so apparently still used. >> .simple_inlinehelp { font-style: italic; font-size: small; font-family: sans-serif; } << Can this be replaced by Bootstrap ? >> .box-share > div { text-align: center;} << Can HTML be simplified, replaced? >> .plugin-form-float << This has many properties so hopefully can be replaced with a Bootstrap class. >> .icon_edit_section { float: right; } .icon_edit_section img.icon { margin-top: -1px !important; } /* Boxes */ .box-title, .box-data << Replaced already with Bootstrap panel classes. >> .modules { position: relative; } << Still needed? >> #role_main .module { max-width: 180px; } << Probably should be replaced with a grid column class. >> h3.box-title << changed to h3.panel-title. >> .moduleflip, .box-title span img.flipmodimage << These still work, I believe. Is there a better way? >> .box-data table { width: 100%; } << tables in modules. Maybe can be removed, but check what Bootstrap does with them. >> .box-data a.linkmenu { display: block; } << Check usage, but maybe not needed. >> .box-data ol, .box-data ul { padding-left: 2em; padding-right: .6em; overflow: hidden; margin-top: 0; margin-bottom: 0; } << Check behavior without these rules. >> .box-months_links ul << Check behavior without these rules. >> .collapsed ul { display: none; } << Needed? >> .modcontrols { display: block; float: right; width: 64px; height: 16px; } << Can be replaced with a global class? >> .minichat, .minichatdiv, .minichatchan { overflow: auto; } << I guess this is necessary. >> /* mod-switch_lang */ .box-switch_lang .box-data img { padding: .2em; vertical-align: middle; } << ? >> .cbox, .cbox-data { overflow: hidden; } << These classes no longer exist. >> #autosave_preview > div { height: 30ex; overflow-y: auto; overflow-x: hidden; } << Probably needed? >> .normal, .normalnoborder, .admin { padding: 0; margin: 0; width: 100%; } << As discussed (Nov 19 a.m.), probably should be changed to Bootstrap classes. >> .ui-accordion .normal, .ui-accordion .normalnoborder, .ui-accordion .admin { width: auto; } << Still needed? >> td { vertical-align: top; } << Can be removed. >> td.third, th, td.heading, tr.diffheader { text-align: center; } << Probably not needed. >> .tabstoggle { font-size: .8em; } << Can the element be given a generic class? >> .tabstoggle .button .tabstoggle.floatright .tabs .tabstoggle.floatright .tabs .tabstoggle.floatright .button << Should be refactored somehow. >> #pageid { float: left; clear: both; } << Why float left when text is align left already? >> .wikiactions { white-space: nowrap !important; } << Maybe ok? >> .split { clear: both; } << Maybe ok? >> #page-bar { display: block; margin-top: 0; } << Isn't display: block by default? Check appearance without these rules. >> #page-bar > span { float: left; } << Probably needed? Check without. >> .hrwikibottom { clear: both; height: 0; visibility: hidden; } << Probably not needed because older browsefs aren't supported any more. >> << Next in design.css come the feature-specific rules. These should be considered separately. Bootstrap doesn't have any awareness of them. They need to be revamped for more global styling, etc. Roughly (r48556) lines 520 t0 1500. >> .center << Will REMOVE. Change class to text-center. >> .justify << No Bootstrap equiv. Probably rename to text-justify. >> .right, .left << No Bootstrap equiv. Probably rename to text-right, -left, but check instances to see if they are necessary or exist due to kludgy code. >> #ajaxLoading << Is there something similar in Bootstrap? Check behavior and find similar. >>

History

Advanced
Information Version
Wed 20 of Nov, 2013 23:14 GMT chibaguy 20
Wed 20 of Nov, 2013 21:04 GMT chibaguy 19
Wed 20 of Nov, 2013 20:48 GMT chibaguy 18
Wed 20 of Nov, 2013 06:52 GMT luci Code Plugin modified by editor. 17
Wed 20 of Nov, 2013 04:39 GMT chibaguy 16
Tue 19 of Nov, 2013 22:19 GMT chibaguy 15
Tue 19 of Nov, 2013 19:39 GMT chibaguy 14
Tue 19 of Nov, 2013 18:58 GMT chibaguy 13
Tue 19 of Nov, 2013 18:16 GMT chibaguy 12
Tue 19 of Nov, 2013 17:19 GMT chibaguy 11
Tue 19 of Nov, 2013 16:59 GMT chibaguy 10
Tue 19 of Nov, 2013 16:34 GMT chibaguy A couple of removals. 9
Tue 19 of Nov, 2013 14:48 GMT chibaguy 8
Tue 19 of Nov, 2013 14:35 GMT chibaguy 7
Tue 19 of Nov, 2013 14:24 GMT chibaguy 6
Tue 19 of Nov, 2013 14:17 GMT chibaguy 5
Tue 19 of Nov, 2013 14:16 GMT chibaguy 4
Tue 19 of Nov, 2013 14:15 GMT chibaguy 3
Tue 19 of Nov, 2013 14:14 GMT chibaguy 2
Tue 19 of Nov, 2013 14:09 GMT chibaguy 1

Switch Theme

Layout

Latest Changes

No records to display ...more

Subscribe to Tiki Newsletters!

Delivered fresh to your email inbox!
Newsletter subscribe icon
Don't miss major announcements and other big news!
Contribute to Tiki

Site Config